👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

pytest tests/models/decoder_only/vision_language/test_models.py -k qwen2_5_vl passed locally on H100, so I'm marking this PR as ready for review.

We need to update requirements-test* as well

IIRC, multiple people reported that the fast processor does not match the original one. Did we consider this issue?

IIRC, multiple people reported that the fast processor does not match the original one. Did we consider this issue?

@WoosukKwon Yea I tried to see if the numerical differences would lead to actual differences in the result, but it looks like that's not the case since the tests all passed (with different image size factors). I'm also okay with us not including use_fast in this PR.

@ywang96 Got it. I'd personally prefer to not use it until we are certain about the correctness.

@ywang96 Got it. I'd personally prefer to not use it until we are certain about the correctness.

Sounds good - I'll revert the change

Since #13617 we no longer need to manually update requirements-test.txt, pre-commit should have us covered.

In a separate PR which also updates transformers I'm seeing some ImportError: cannot import name 'LogitsWarper' from 'transformers.generation.logits_process' errors in CI https://buildkite.com/vllm/ci/builds/13915#01952838-c668-4156-9ac4-d0ce260584d1 originating from lm-format-enforcer.

It'd be good to check if this happens here too.

In a separate PR which also updates transformers I'm seeing some ImportError: cannot import name 'LogitsWarper' from 'transformers.generation.logits_process' errors in CI https://buildkite.com/vllm/ci/builds/13915#01952838-c668-4156-9ac4-d0ce260584d1 originating from lm-format-enforcer.

It'd be good to check if this happens here too.

@hmellor Thanks for the heads up!

Rebuilding